-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin virtualenv version to 20.20.0 #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just need a changelog entry, otherwise lgtm
Awesome find! Should we perhaps make this more general and pin all dependencies? |
I'd prefer we not, same as our other packages, we should only set minimum required versions.... in fact for this, we could probably just do |
IMO we should install riot in its isolated environment as a stand-alone tool (e.g. with |
Should it be a |
We aren't the only users of If we want we can/should have a pipx/pip-compile lock file for riot where we install it in our CI environment? |
@P403n1x87 we can probably handle as a follow-up, since this fix vs changing how riot defines dependencies can be separated. wdyt? |
👍 yep, that's fine by me. |
Virtualenv dropped support for Python 2.7, so we need to pin this requirement in order to keep creating 2.7 virtualenvs